Allow signing deployment transactions with a private key #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smessmer
force-pushed
the
feature/signed_deploy
branch
2 times, most recently
from
b60bf94
to
284ab62
Compare
tomusdrw
reviewed
Mar 15, 2021
smessmer
force-pushed
the
feature/signed_deploy
branch
from
0d5a228
to
6e39d9c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All previous API points to deploy contracts relied on the ethereum node to have the private keys for the account to deploy from. This PR adds an API for deploying contracts while keeping the private keys away from the ethereum node.